Closed
Conversation
- Fixed blob fee calculation logic in Blob transaction type - Added judgment for weiAmt being nil to avoid potential null pointer exceptions
Fix transaction fee calculation issue
- Add a mutex to ensure thread-safe access to latestBlockTime - Implement SetLatestBlockTime and GetLatestBlockTime methods - Update StartMonitoring and IsGrowth methods to use new thread-safe accessors
…2Staking.t.sol` (#717)
Co-authored-by: chengwenxi <22697326+chengwenxi@users.noreply.github.com> Co-authored-by: FletcherMan <fanciture@163.com> Co-authored-by: curryxbo <curryx1992@gmail.com> Co-authored-by: kukoomomo <kukoomomo@gmail.com> Co-authored-by: Kathy <22675649+anylots@users.noreply.github.com>
* fix last indexed blockbum not load * refactor logs for feesum
Co-authored-by: WorldDogs <noreply.io>
- Add BatchFetcher interface for fetching batch data from nodes - Modify BatchCache to fetch from nodes when cache misses - Add BatchFetcher implementation in services - Update tests with proper mock and concurrent testing - Add Clear method to BatchCache - Improve thread safety for concurrent operations This change allows BatchCache to automatically fetch data from nodes when the requested batch is not found in cache, improving the service reliability and reducing manual handling of cache misses.
Pass BatchFetcher instance to BatchCache constructor in Rollup service to enable fetching batch data from L2 nodes when cache misses occur.
enhance batch cache
Replaced the LondonSigner with LatestSignerForChainID in the Rollup service initialization to ensure compatibility with the latest Ethereum chain standards.
refactor: update signer to use LatestSignerForChainID
Co-authored-by: chengwenxi <22697326+chengwenxi@users.noreply.github.com>
Co-authored-by: WorldDogs <noreply.github.com>
Co-authored-by: WorldDogs <noreply.github.com>
Co-authored-by: WorldDogs <noreply.github.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.